Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump deps, misc cleanup of old IPC abstraction code of client #43

Merged
merged 2 commits into from
Jun 20, 2024
Merged

bump deps, misc cleanup of old IPC abstraction code of client #43

merged 2 commits into from
Jun 20, 2024

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jun 20, 2024

What this does:

  • Bumps the socketcan dep (breaking change) and paho mqtt dependencies
  • Removes the unused abstraction of the client interface as there is only MQTT left in the application
  • Removes uneeded command line arguments (ipc) and command line configuration that doesnt work on odysseus (can_configure)

@jr1221 jr1221 requested a review from dyldonahue June 20, 2024 21:50
dyldonahue
dyldonahue approved these changes Jun 20, 2024
View reviewed changes
Copy link

@dyldonahue dyldonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting that u know what ur doing on the big chunks of removed functions

@jr1221 jr1221 merged commit 3f9dcf7 into Develop Jun 20, 2024
1 check passed
@jr1221 jr1221 deleted the bump-deps branch June 20, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyldonahue dyldonahue dyldonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jr1221 @dyldonahue