Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CANErrorFrame, move decode logic up to read_frame match #54

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Handle CANErrorFrame, move decode logic up to read_frame match #54

merged 8 commits into from
Oct 3, 2024

Conversation

harrison-e
Copy link
Contributor

No description provided.

jr1221
jr1221 requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some stuff to add. didnt test yet but will soon. We can talk thursday (or if u can go Sunday) about my comments.

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@jr1221 jr1221 merged commit 80b17cd into Develop Oct 3, 2024
1 check passed
@harrison-e harrison-e deleted the origin/harry-dev branch October 4, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jr1221 jr1221 jr1221 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrison-e @jr1221