Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate decode and encode from JSON over YAML, #60

Merged
merged 12 commits into from
Oct 4, 2024
Merged

Conversation

harrison-e
Copy link
Contributor

Changes

  • main.rs now handles CAN Error and Remote frames.
  • calypsogen.py now uses JSON over YAML. See Embedded-Base/cangen/README.md.

To Do

Any remaining things that need to get done

  • Macros

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #35

@harrison-e harrison-e requested a review from jr1221 October 4, 2024 00:13
@harrison-e harrison-e self-assigned this Oct 4, 2024
jr1221
jr1221 previously approved these changes Oct 4, 2024
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jr1221
Copy link
Contributor

jr1221 commented Oct 4, 2024

Switch submodule to develop embedded base, check CI and if works u can merge.

@dyldonahue
Copy link

the pain in seeing a failed check

@jr1221 jr1221 merged commit 547a8da into Develop Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Undecodable Messages to Server
3 participants