Making functions take the correct parameters

Northeastern-Electric-Racing · Nov 24, 2023 · 6d545e3 · 6d545e3
1 parent b49cb29
commit 6d545e3
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 31 deletions.
diff --git a/Core/Inc/pdu.h b/Core/Inc/pdu.h
@@ -4,28 +4,33 @@
 #include <stdint.h>
 #include <stdbool.h>
 #include "pi4ioe.h"
+#include "cmsis_os.h"
 
-typedef pi4ioe_t pdu_t;
+typedef struct {
+    pi4ioe_t *gpio_exp;
+    osMutexId_t *mutex;
+} pdu_t;
 
-pdu_t *init_pdu();
+/* Creates a new PDU interface */
+pdu_t *init_pdu(I2C_HandleTypeDef *hi2c);
 
 /* Functions to Control PDU */
-int8_t write_pump(pdu_t *pdu_exp, bool status);
-int8_t write_fan_radiator(pdu_t *pdu_exp, bool status);
-int8_t write_brakelight(pdu_t *pdu_exp, bool status);
-int8_t write_fan_battbox(pdu_t *pdu_exp, bool status);
+int8_t write_pump(pdu_t *pdu, bool status);
+int8_t write_fan_radiator(pdu_t *pdu, bool status);
+int8_t write_brakelight(pdu_t *pdu, bool status);
+int8_t write_fan_battbox(pdu_t *pdu, bool status);
 
 /* Functions to Read the Status of Fuses from PDU */
-int8_t read_fuse_pump(pdu_t *pdu_exp);
-int8_t read_fuse_fan_radiator(pdu_t *pdu_exp);
-int8_t read_fuse_fan_battbox(pdu_t *pdu_exp);
-int8_t read_fuse_mc(pdu_t *pdu_exp);
-int8_t read_fuse_lvbox(pdu_t *pdu_exp);
-int8_t read_fuse_dashboard(pdu_t *pdu_exp);
-int8_t read_fuse_brakelight(pdu_t *pdu_exp);
-int8_t read_fuse_brb(pdu_t *pdu_exp);
+int8_t read_fuse_pump(pdu_t *pdu);
+int8_t read_fuse_fan_radiator(pdu_t *pdu);
+int8_t read_fuse_fan_battbox(pdu_t *pdu);
+int8_t read_fuse_mc(pdu_t *pdu);
+int8_t read_fuse_lvbox(pdu_t *pdu);
+int8_t read_fuse_dashboard(pdu_t *pdu);
+int8_t read_fuse_brakelight(pdu_t *pdu);
+int8_t read_fuse_brb(pdu_t *pdu);
 
 /* Function to read the status of Tractive System Main Switch */
-int8_t read_tsms_sense(pdu_t *pdu_exp);
+int8_t read_tsms_sense(pdu_t *pdu);
 
 #endif /* PDU_H */
diff --git a/Core/Src/pdu.c b/Core/Src/pdu.c
@@ -7,21 +7,18 @@
 #define TSMS_CTRL 			0x04
 #define SMBALERT	 		0x05
 
-int8_t write_pump(pdu_t *pdu_t, bool status);
+pdu_t *init_pdu(I2C_HandleTypeDef *hi2c);
 
+int8_t write_pump(pdu_t *pdu, bool status);
 int8_t write_fan_radiator(pdu_t *pdu_t, bool status);
-int8_t write_brakelight(pdu_t *pdu_exp, bool status);
-int8_t write_fan_battbox(pdu_t *pdu_exp, bool status);
-
-/* Functions to Read the Status of Fuses from PDU */
-int8_t read_fuse_pump(pdu_t *pdu_exp);
-int8_t read_fuse_fan_radiator(pdu_t *pdu_exp);
-int8_t read_fuse_fan_battbox(pdu_t *pdu_exp);
-int8_t read_fuse_mc(pdu_t *pdu_exp);
-int8_t read_fuse_lvbox(pdu_t *pdu_exp);
-int8_t read_fuse_dashboard(pdu_t *pdu_exp);
-int8_t read_fuse_brakelight(pdu_t *pdu_exp);
-int8_t read_fuse_brb(pdu_t *pdu_exp);
-
-/* Function to read the status of Tractive System Main Switch */
-int8_t read_tsms_sense(pdu_t *pdu_exp);
+int8_t write_brakelight(pdu_t *pdu, bool status);
+int8_t write_fan_battbox(pdu_t *pdu, bool status);
+int8_t read_fuse_pump(pdu_t *pdu);
+int8_t read_fuse_fan_radiator(pdu_t *pdu);
+int8_t read_fuse_fan_battbox(pdu_t *pdu);
+int8_t read_fuse_mc(pdu_t *pdu);
+int8_t read_fuse_lvbox(pdu_t *pdu);
+int8_t read_fuse_dashboard(pdu_t *pdu);
+int8_t read_fuse_brakelight(pdu_t *pdu);
+int8_t read_fuse_brb(pdu_t *pdu);
+int8_t read_tsms_sense(pdu_t *pdu);