-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Receiver #132
Merged
Merged
Receiver #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
approved these changes
Feb 4, 2024
nwdepatie
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good
nwdepatie
pushed a commit
that referenced
this pull request
Feb 4, 2024
* Disabled outgoing can * Made reciever build * Trying to make CAN work - 1/22 * temp changes * Made CAN Sorta Work * Made interrupts work * Cleaned up dummy changes * fixed typo * Made ioc changes
nwdepatie
pushed a commit
that referenced
this pull request
Feb 4, 2024
* Disabled outgoing can * Made reciever build * Trying to make CAN work - 1/22 * temp changes * Made CAN Sorta Work * Made interrupts work * Cleaned up dummy changes * fixed typo * Made ioc changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verified that CAN messages make it to the receive buffer and also verified that the callback is being triggered. The changes to make this work were not exclusively in cerberus and Embedded Base also has some necessary changes to make this work.
To Do
Refine the callback function and make that actually work and verify that CAN messages are being verified.