Pedal to torque #254
Open
Pedal to torque #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiodasilva2005
requested changes
Jan 13, 2025
Core/Src/pedals.c
Outdated
| @@ -371,8 +390,12 @@ void handle_endurance(dti_t *mc, float mph, float accel_val, float brake_val) | |||
| if (brake_val > 650 && (mph * 1.609) > 5) { | |||
| brake_pedal_regen(brake_val); | |||
| } else { | |||
| // accelerating, limit torque | |||
| // accelerating, limit torque | |||
| #ifndef POWER_REGRESSION_PEDAL_TORQUE_TRANSFER | |||
There was a problem hiding this comment.
We don't want this for brake regen, just for linear accel -> torque
jr1221
reviewed
Jan 14, 2025
| @@ -27,7 +27,7 @@ | |||
| 0x496 /* Throttle signal, Brake signal, IO, Drive enable */ | |||
|
|
|||
| #define TIRE_DIAMETER 16 /* inches */ | |||
| #define GEAR_RATIO 47 / 13.0 /* unitless */ | |||
| #define GEAR_RATIO 35 / 13.0 /* unitless */ | |||
There was a problem hiding this comment.
I messaged Abby directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
_New pedal to torque transfer curve as shown below. Between 0 and 20% pedal throttle the applied throttle is about halved, then afterwards it slowly approaches a 1:1 applied vs outputted throttle.
Test Cases
To Do
Closes #248