Make Lsm6dso platform agnostic #162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
requested changes
Sep 30, 2024
general/include/lsm6dso.h
Outdated
| */ | ||
| HAL_StatusTypeDef lsm6dso_init(lsm6dso_t *imu, I2C_HandleTypeDef *i2c_handle); | ||
| int lsm6dso_init(I2C_HandleTypeDef *i2c_handle, I2C_Read read_func, I2C_Write write_func); |
There was a problem hiding this comment.
I2C_HandleTypeDef is an stm32 HAL dependency. This should be removed form driver - can be hidden in the wrapper functions on the app later as a hardcoded parameter
* moved system into py module * resctructured dir * openOCD install
* added flash and ftdi support * ceanup * add ftdi flash file * flash ftdi and swd works * usbip works * serial works * build on all cores * review fixes --------- Co-authored-by: Jack Rubacha <[email protected]>
* try add prietter enforce * exclude vl6180x * reformat and fixes * more fixes * try ignore again
dyldonahue
approved these changes
Oct 13, 2024
|
Waiting till Cerb migration is done |
* wsl flash, serial work with confluence docs * working debug * fixup * works on linux * works again on windows * flash and debug ftdi works on windows
* added sim code generation * JSON definitions for most of YAML (still in progress) * remove sneaky quotes * created struct for constructor params --------- Co-authored-by: Jack Rubacha <[email protected]>
* typer * possible miniterm fix * list --> ls * fixed update path * deprecated docker command + unspported cb handler * fixed unsupport --------- Co-authored-by: Jack Rubacha <[email protected]>
* Finished Refactoring LTC4015 Ticket (cherry picked from commit 23300d2) cherry picked commit * Added Function Pointer as Argument (cherry picked from commit 9a1a805) cherry picked commit * unrelated bug --------- Co-authored-by: Daniel Nakhooda <[email protected]>
* deprecate YAML modules from init --------- Co-authored-by: Jack Rubacha <[email protected]>
caiodasilva2005
added a commit
that referenced
this pull request
Oct 27, 2024
caiodasilva2005
added a commit
that referenced
this pull request
Oct 27, 2024
* generalized funcs * changed function names * fixed naming * fully generalized * removed i2c handle * imu pointer in param * fixed header * #162-fixed param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made function wrappers for HAL specific driver functions, and added function pointers to lsm6dso_t.
Closes #156