bug/MessageFiltering #186
Merged
bug/MessageFiltering #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr1221
requested changes
Oct 27, 2024
There was a problem hiding this comment.
See comments and obviously going to have to test this.
This looks good, but imo the user should just call add_can_filter and pass in the 4 IDs. That way you avoid the ugly code. The user (ex. cerberus) would just then:
add_can_filter(hcan, id_list_a)
add_can_filter(hcan, id_list_b)
init_can(hcan)
|
One more thing, you can probably remove the id_list stuff from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix Can Message Filtering.
Closes # (issue #184)