pi4io3 Driver Agnostic #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyldonahue
requested changes
Oct 27, 2024
| HAL_StatusTypeDef pi4ioe_init(pi4ioe_t *gpio, I2C_HandleTypeDef *i2c_handle) | ||
| typedef (*I2C_WriteFuncPtr)(uint16_t device_addr, uint8_t *data, uint16_t size); | ||
| typedef (*I2C_ReadFuncPtr)(uint16_t device_addr, uint8_t *reg, | ||
| uint16_t reg_size, uint8_t *data, |
There was a problem hiding this comment.
not sure that reg size is needed here. Both read na dwrite cna just take "data, reg, length)
| @@ -23,49 +23,61 @@ | |||
| uint8_t oreg_1_data; | |||
| uint8_t oreg_2_data; | |||
|
|
|||
| HAL_StatusTypeDef pi4ioe_init(pi4ioe_t *gpio, I2C_HandleTypeDef *i2c_handle) | |||
| typedef (*I2C_WriteFuncPtr)(uint16_t device_addr, uint8_t *data, uint16_t size); | |||
| typedef (*I2C_ReadFuncPtr)(uint16_t device_addr, uint8_t *reg, | |||
There was a problem hiding this comment.
nitpick but can the names be changed :
I2C_WriteFuncPtr --> WritePtr
... --> ReadPtr
i2c_write --> write
i2c_read --> read
| uint16_t data_size); | ||
|
|
||
| typedef struct { | ||
| uint16_t i2c_addr; // I2C address of the GPIO expander |
There was a problem hiding this comment.
this can be handled at app layer, we dont need tos tore the i2c address here
|
Look at Caio's PR in MSB FW as a good example for implementing the new style driver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaced HAL specific code with generalized code with pointers for HAL functionality.
Closes #159