Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated INA226 driver #190

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Updated INA226 driver #190

merged 6 commits into from
Nov 7, 2024

Conversation

bjackson312006
Copy link
Contributor

Changes

  • Added missing #endif to INA226.h
  • Added #include <stdint.h> and #include <math.h> to INA226.h
  • Fixed ina226_reset, ina226_read_manufacturer_id, and ina226_read_die_id params

Notes

These issues were preventing me from building Cerberus

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (#152)

@bjackson312006 bjackson312006 self-assigned this Nov 7, 2024
@bjackson312006 bjackson312006 marked this pull request as ready for review November 7, 2024 03:37
@bjackson312006 bjackson312006 requested a review from jr1221 November 7, 2024 03:38
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bjackson312006 bjackson312006 merged commit e230b02 into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants