Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowpass filter #202

Closed
wants to merge 2 commits into from
Closed

Lowpass filter #202

wants to merge 2 commits into from

Conversation

DimitryP6
Copy link
Contributor

Changes

Created a exponential moving average lowpass filter

Notes

alpha seems to work well for 0.1

Test Cases

int main() {
float noisy_signal[] = {10.0, 20.0, 15.0, 25.0, 20.0};
for (int i = 0; i < 5; i++){
// Something like this: ema_filter(noisy_signal[i], &previous_ema, alpha);
}
return 0;
}

To Do

seems finished

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • [ *] All commits are tagged with the ticket number
  • [ *] No merge conflicts
  • [ *] All checks passing
  • [ *] Remove any non-applicable sections of this template
  • [ *] Assign the PR to yourself
  • [* ] Request reviewers & ping on Slack
  • [* ] PR is linked to the ticket (fill in the closes line below)

Closes #173

@DimitryP6 DimitryP6 requested a review from jr1221 November 20, 2024 04:38
@DimitryP6 DimitryP6 self-assigned this Nov 20, 2024
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a simple_ema.h file in includes so that the function can be publicly called. Please move your comment on top of the function there as well.

@DimitryP6 DimitryP6 closed this Dec 2, 2024
@DimitryP6 DimitryP6 deleted the lowpass_filter branch December 2, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop stable low pass filter algorithms for voltages and temperatures
2 participants