Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bms mock #204

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fixed bms mock #204

merged 1 commit into from
Nov 21, 2024

Conversation

bracyw
Copy link
Contributor

@bracyw bracyw commented Nov 21, 2024

Changes

Just changed sys_inc_min to 0 (so we don't get decimal increments)

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #203

@bracyw bracyw self-assigned this Nov 21, 2024
@bracyw bracyw requested a review from jr1221 November 21, 2024 22:34
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge if tested.

@bracyw bracyw merged commit 970cceb into main Nov 21, 2024
2 checks passed
@jr1221 jr1221 deleted the can-mock-fix branch November 21, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAN sys inc wrong for bms faults
2 participants