Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated driver #213

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Updated driver #213

merged 2 commits into from
Dec 5, 2024

Conversation

Myers-Ty
Copy link
Contributor

@Myers-Ty Myers-Ty commented Dec 5, 2024

Changes

Updated the LSM6DSO driver with the STM variant.

Notes

This is in conjunction with another ticket inside MSB:
Switch lsm6dso to STM driver, test on MSB #191

Issues

Jack mentioned it would break Cerberus and this is a seperate issue to my ticket

Closes #191

@Myers-Ty Myers-Ty added the enhancement New feature or request label Dec 5, 2024
@Myers-Ty Myers-Ty requested a review from jr1221 December 5, 2024 01:29
@Myers-Ty Myers-Ty self-assigned this Dec 5, 2024
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an OEM driver, we dont care about formatting it. Therefore can you add it to this file like vl6180x?

Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. will fix cerb myself.

@Myers-Ty Myers-Ty merged commit bbfb6c5 into main Dec 5, 2024
1 of 2 checks passed
@jr1221 jr1221 deleted the LSM6DSO-Driver-Update branch December 5, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch lsm6dso to STM driver, test on MSB
2 participants