CAN spec patches #218
Merged
CAN spec patches #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed from 24 to 27 bits.
…add to 1. Mode option 1 from 0.80 to 0.79, and ModeIndex option 2 from 0.40 to 0.20.
warrants a new GH achievement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Calypso now validates the CAN spec in
cangen/can-messages/(see Northeastern-Electric-Racing/Calypso#85), and has exposed some minor flaws in the spec. This is a quick patch to fix them:charger.json:0x18FF50E5(Charger Box Status) is now byte aligned, adding up to 64 bits instead of 61 bits. Changed unused portion from 24 to 27 bits.mpu.json:MPU/State/Modenow add to 1 instead of 1.01. Changed option 1 frequency from0.80to0.78, and option 4 frequency from0.00to0.01.MPU/State/ModeIndexnow add to 1 instead of 1.2. Changed option 2 frequency from0.4to0.2.MPU/Sense/SOCno longer specifies endianness, since it's only 8 bits.Test Cases