Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in more scripting for Docker #77

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Add in more scripting for Docker #77

merged 5 commits into from
Feb 19, 2024

Conversation

nwdepatie
Copy link
Contributor

Changes

I think we were constraining ourselves with only allowing like one liner bash commands for aliases. Instead, I've exploded out all the bash aliases into their own files, which should allow for more flexibility while using, i.e. by passing arguments or implementing more complex logic for locating files, etc.

This should add A LOT more possibilities for what we can do when we start up

Notes

I also added Proteus ASCII art to the alias script

Test Cases

  • Built in Docker
  • All aliases worked like before
  • Libncurses is installed and debug works

@nwdepatie nwdepatie self-assigned this Feb 19, 2024
Copy link
Contributor

@dyldonahue dyldonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you want to address the dockerfile in Shepherd? is it an easy delete, or will things get messy

@nwdepatie
Copy link
Contributor Author

How do you want to address the dockerfile in Shepherd? is it an easy delete, or will things get messy

Prob easy delete, will probably be best to replace with a docker compose

@nwdepatie nwdepatie merged commit 5f0c2e2 into main Feb 19, 2024
1 check passed
@nwdepatie nwdepatie deleted the add-ncurses branch February 19, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants