optimized method for filtering optional users

Northeastern-Electric-Racing · Dec 23, 2024 · 85f92ca · 85f92ca
1 parent aa20a64
commit 85f92ca
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/frontend/src/pages/CalendarPage/DesignReviewDetailPage/DesignReviewDetailPage.tsx b/src/frontend/src/pages/CalendarPage/DesignReviewDetailPage/DesignReviewDetailPage.tsx
@@ -104,10 +104,8 @@ const DesignReviewDetailPage: React.FC<DesignReviewDetailPageProps> = ({ designR
   };
 
   const handleSelectingRequiredUser = (newValue: { label: string; id: string }[]) => {
-    let filteredOptionalUsers = optionalUsers;
-    for (const reqUser of newValue) {
-      filteredOptionalUsers = filteredOptionalUsers.filter((user) => user.id !== reqUser.id);
-    }
+    const newRequiredUserIds = new Set(newValue.map((user) => user.id));
+    const filteredOptionalUsers = optionalUsers.filter((user) => !newRequiredUserIds.has(user.id));
     setOptionalUsers(filteredOptionalUsers);
     setRequiredUsers(newValue);
   };