#2104 delete manufac

[will-anderson0]

Changes

I made the delete button next to the manufacturers so you can delete them and there is a warning that pops up to check if you want to confirm.

Notes

The actual deletion of the manufacturers works but only visually, it does not delete out of the database so when you go to create a new manufacturer it loads everything that should have been deleted plus the manufacturer you just made. I tried to make an endpoint to delete the manufacturer but I am not sure where I went wrong.

Screenshots

To Do

Any remaining things that need to get done

• Delete the manufacturer out of the database, currently only deletes visually

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

• All commits are tagged with the ticket number
• No linting errors / newline at end of file warnings
• All code follows repository-configured prettier formatting
• No merge conflicts
• All checks passing
• Screenshots of UI changes (see Screenshots section)
• Remove any non-applicable sections of this template
• Assign the PR to yourself
• No yarn.lock changes (unless dependencies have changed)
• Request reviewers & ping on Slack
• PR is linked to the ticket (fill in the closes line below)

Closes #2104

[ryanhowe28]

Should not have yarn lock changes

[ryanhowe28]

Something got extremely messed up all of your checks are failing right now. Think it had to do with your yarn lock stuff

[ryanhowe28]

Looks pretty good, just small changes

[ryanhowe28]

LGTM

[walker-sean]

Nice job so far!

[RChandler234]

right now the endpoint is erroring but not actually showing the error in the frontend, I think removing the two asyncs should fix it, but lmk if it doesn't

[RChandler234]

This one's weirder than I initially thought, get me at the meeting tmrw and I can explain how to do it more, but basically, we're going to have to go back to soft deleting manufacturers in the database (gonna require a schema change and changing the backend endpoints a bit)

[ryanhowe28]

1. Change the schema to have a dateDeleted field for a manufacturer, kinda opposite of what this PR did, this will be a custom migration so we dont wanna do a prisma migrate but we will need to manually edit the sql files ourselves, #1989 hard deleted delete manufacturer endpoint #2044

2. edit the endpoints that this effects

[ryanhowe28]

Then we are going to wanna display the manufacturers where the query args say it is true, remember what reid was showing in the meeting, will probably need to add it in, take a look at some of the other stuff we have dateDeleted for and see how they do it

[RChandler234]

LGTM 🔥