Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2131 Create DRC create modal #2208

Merged
merged 18 commits into from
Mar 19, 2024
Merged

#2131 Create DRC create modal #2208

merged 18 commits into from
Mar 19, 2024

Conversation

alaneng-neu
Copy link
Contributor

@alaneng-neu alaneng-neu commented Mar 15, 2024

Changes

Created DRC create modal

Notes

Still unfinished, needs to be hooked up to create modal hook

Screenshots

Currently unfinished (date, start and end time)
image

To Do

  • delete temp testing for DRC create modal in the home page
  • move modal to DR page directory
  • add form inputs for required/optional attendees
  • add form input for team type
  • hook up form to create modal hook

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2131

@alaneng-neu alaneng-neu changed the title #2131 Create base of DRC create modal #2131 Create DRC create modal Mar 15, 2024
@alaneng-neu alaneng-neu marked this pull request as draft March 15, 2024 01:31
@RChandler234 RChandler234 self-assigned this Mar 17, 2024
@RChandler234 RChandler234 marked this pull request as ready for review March 17, 2024 21:30
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walker-sean walker-sean merged commit a305fa9 into develop Mar 19, 2024
4 checks passed
@walker-sean walker-sean deleted the #2131-drc-create-modal branch March 19, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Review Calendar - Time Scheduled Pop Up
4 participants