Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2062 created hook for single design review #2220

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

Aaryan1203
Copy link
Contributor

Changes

Created a hook and api call for getting single design review

Test Cases

  • wrote a unit test

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2062

@Aaryan1203 Aaryan1203 self-assigned this Mar 18, 2024
Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the designReview is showing up correctly, you should wire this up so it shows the availabilities for all the requested attendees (optional and required), and the required/ optional select things have their value set as the current value for required and optional attendees on the fetched design review (don't worry about hooking up the actual edit)

Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@RChandler234 RChandler234 merged commit 9c260ed into develop Mar 18, 2024
4 checks passed
@RChandler234 RChandler234 deleted the #2062-single-design-review-hook branch March 18, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Review Calendar - Use Single Design Review Hook
2 participants