Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2217 wire drc page #2222

Merged
merged 4 commits into from
Mar 18, 2024
Merged

#2217 wire drc page #2222

merged 4 commits into from
Mar 18, 2024

Conversation

walker-sean
Copy link
Member

Changes

Got the DRs, tooltips, and unconfirmed DRs showing up right

Notes

The code is messy but things are actually looking half decent. For some reason the modal closes when you click 'mark as done' only if it was one of the extra events. Idk why

Screenshots

image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2217

@walker-sean walker-sean self-assigned this Mar 18, 2024
@RChandler234
Copy link
Contributor

I think the bug with the modal closing is because the tooltip is still open, so it steals the focus on the screen when u click the checkbox. There's a e.stopPropagation thing you might be able to use to stop it, or maybe just make sure the tooltip closes when you click one of the options

@ryanhowe28 ryanhowe28 linked an issue Mar 18, 2024 that may be closed by this pull request
4 tasks
@RChandler234 RChandler234 merged commit d8e8236 into develop Mar 18, 2024
4 checks passed
@RChandler234 RChandler234 deleted the #2217-wire-drc-page branch March 18, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Review Calendar - Wire up DRC page Design Review Calendar - Create Design Review Hook
2 participants