Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2223: Design Review mark user confirmation endpoint #2225

Merged
merged 16 commits into from
Mar 19, 2024

Conversation

martin0he
Copy link
Contributor

@martin0he martin0he commented Mar 18, 2024

Changes

created an endpoint that marks the current user as confirmed for a given design review, and sets their schedule setting's availability to the given availability array

Test Cases

  • When the user doesn't have schedule settings
  • When the array of availabilities has only 1 element
  • given user isn't optional nor required
  • availabilities arent between 0 and 83 inclusive
  • when the design review doesn't exist
  • when the design review has been deleted

Screenshots

image
image
image
image
image
image
image
image
image

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #2223

@martin0he martin0he self-assigned this Mar 18, 2024
@martin0he martin0he linked an issue Mar 18, 2024 that may be closed by this pull request
7 tasks
@martin0he
Copy link
Contributor Author

this is my postman setup
image
image

@martin0he martin0he requested a review from RChandler234 March 18, 2024 20:35
@martin0he martin0he requested a review from RChandler234 March 19, 2024 02:19
Copy link
Contributor

@RChandler234 RChandler234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@RChandler234 RChandler234 merged commit 685f31a into develop Mar 19, 2024
4 checks passed
@RChandler234 RChandler234 deleted the #2223-design-review-calendar-mark-user-confirmed branch March 19, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Review Calendar - Mark User Confirmed
2 participants