#3060-Edit Organization Logo #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
requested changes
Dec 16, 2024
src/frontend/public/default-logo.png
Outdated
There was a problem hiding this comment.
this should not be here
| return await downloadGoogleImage(fileId); | ||
| } catch { | ||
| // return default logo if fileId was not found | ||
| return await getDefaultImageData(); |
There was a problem hiding this comment.
no lets not do this. return undefined if it. doesnt exist
| @@ -1,5 +1,5 @@ | |||
| -- AlterTable | |||
| ALTER TABLE "Organization" ADD COLUMN "logoImage" TEXT; | |||
| ALTER TABLE "Organization" ADD COLUMN "logoImageId" TEXT; | |||
There was a problem hiding this comment.
ensure at some point you consolidate all of your migration files to just one migration called home-page-redesign
Peyton-McKee
requested changes
Dec 20, 2024
|
|
||
| const EditLogo = () => { | ||
| const { data: organization, isLoading: organizationIsLoading } = useCurrentOrganization(); | ||
| const { data: imageData, isLoading: imageDataIsLoading } = useOrganizationLogo(); |
There was a problem hiding this comment.
add error handling for these queries. Ensure all useQueries added have proper error handling.
|
|
||
| const onSubmit = async (logoInput: EditLogoInput) => { | ||
| try { | ||
| console.log(logoInput); |
| try { | ||
| console.log(logoInput); | ||
| if (!logoInput.logoImage) { | ||
| handleClose(); |
There was a problem hiding this comment.
we should probably toast why were closing
| <NERFailButton sx={{ mx: 1 }} form={'edit-organization-logo'} onClick={onHideWrapper}> | ||
| Cancel | ||
| </NERFailButton> | ||
| <NERSuccessButton |
There was a problem hiding this comment.
this is weird. were gonna be submitting twice. Wee should remove this onclick prop and delete the onSubmitWrapper.
Peyton-McKee
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added an admin tool to update the organization's logo
Notes
Screenshots
*Video in slack thread
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3060