Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3097 delete checklist hook #3098

Merged

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Dec 22, 2024

Changes

  • hook complete
  • hooked it up to the icon button in the admin tools
  • used NERDeleteModal

Screenshots

Screenshot 2024-12-22 at 6 07 11 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #3097 )

@superhvarn superhvarn changed the base branch from develop to feature/recruitment_and_onboarding December 22, 2024 23:05
Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you delete something from the general checklist, the entire checxklist moves down and becomes the second checklist. Can you make it so that general checklist is always first and the rest of them are alphabetical

Copy link
Contributor

@Aaryan1203 Aaryan1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaryan1203 Aaryan1203 merged commit 25fe8b6 into feature/recruitment_and_onboarding Jan 2, 2025
4 checks passed
@Aaryan1203 Aaryan1203 deleted the #3097-delete-checklist-hook branch January 2, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants