Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2815 make progress bar reactive #3103

Merged

Conversation

superhvarn
Copy link
Contributor

@superhvarn superhvarn commented Dec 30, 2024

Changes

  • onboarding progress bar fills up when team type checklists and general checklists are filled
  • finished button enables when it is at 100
  • team type checklists and general checklists have progress bars which fill when its tasks are completed
  • every task including subtask checks and stays checked when reloaded
  • new hook for toggling checklist
  • fixed up getUserTeamTypeChecklists and getGeneralChecklists to include userChecked for subtasks

Screenshots

Screenshot 2024-12-30 at 11 36 19 AM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #2815)

@superhvarn superhvarn changed the base branch from develop to feature/recruitment_and_onboarding December 30, 2024 16:36
@superhvarn superhvarn force-pushed the #2815-Make-Progress-bar-reactive branch from 42eb1e5 to c0e4225 Compare December 30, 2024 16:56
Copy link
Contributor

@Peyton-McKee Peyton-McKee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix merge conflicts before i leave a larger review

@Peyton-McKee Peyton-McKee merged commit 85acc57 into feature/recruitment_and_onboarding Jan 13, 2025
4 checks passed
@Peyton-McKee Peyton-McKee deleted the #2815-Make-Progress-bar-reactive branch January 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants