Feature/homepage old history #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peyton-McKee
commented
Jan 9, 2025
src/backend/src/prisma/schema.prisma
Outdated
| popUpId String @id @default(uuid()) | ||
| text String | ||
| iconName String | ||
| users User[] @relation("userPopUps") |
There was a problem hiding this comment.
this is usersUnread right? And when they read the popup they get removed from this list?
| slackEventId: string, | ||
| slackChannelName: string, | ||
| organizationId: string | ||
| ): Promise<Announcement> { |
There was a problem hiding this comment.
we should probably validate that the usersReceivedIds are all valid ids. otherwise were gonna throw a weird error
| * @returns the user's updated unread pop up | ||
| */ | ||
| static async removeUserPopUp(userId: string, popUpId: string, organizationId: string) { | ||
| const updatedUser = await prisma.user.update({ |
There was a problem hiding this comment.
i think we need to verify that the popUpId exists before this.
| where: { userId }, | ||
| include: { assignedTasks: getTaskQueryArgs(organization.organizationId) } | ||
| }); | ||
| if (!requestedUser) throw new NotFoundException('User', userId); |
There was a problem hiding this comment.
i think we need to check if a user is in the organization as well
| */ | ||
| export const getProjects = async (projectIds: string[], organizationId: string) => { | ||
| const projects = await prisma.project.findMany({ | ||
| where: { projectId: { in: projectIds } }, |
There was a problem hiding this comment.
dateDeleted === null
There was a problem hiding this comment.
wbsElement: { organizationId } aswell
…pdates Fixed Backend Checks On Homepage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Homepage changes
Finishline_HomepageRedesign_Overview.zip
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #2012 (issue #)