-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3124: first drafts of schema models #3127
Merged
walker-sean
merged 14 commits into
feature/cad-project-file-review
from
#3124-create-cad-review-models
Jan 27, 2025
Merged
#3124: first drafts of schema models #3127
walker-sean
merged 14 commits into
feature/cad-project-file-review
from
#3124-create-cad-review-models
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chpy04
force-pushed
the
#3124-create-cad-review-models
branch
from
January 20, 2025 15:32
fffdd16
to
d7e6e97
Compare
gcooper407
reviewed
Jan 21, 2025
gcooper407
changed the base branch from
develop
to
feature/cad-project-file-review
January 22, 2025 23:57
gcooper407
requested review from
Peyton-McKee and
walker-sean
and removed request for
Peyton-McKee
January 23, 2025 00:03
chpy04
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
walker-sean
requested changes
Jan 23, 2025
walker-sean
requested changes
Jan 24, 2025
walker-sean
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added models for cad review data structures
Notes
We are now using the pre-existing FAQ model for two different types of FAQs. Because of this, there are two relations in the organization model to two arrays of FAQs. This means every FAQ will have either a regularFaqOrg field or a partReviewFaqOrg field. This can't be enforced in prisma so it is enforced in the migration. The migration also changes the name of the primary key for the original faqs.
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lock
changes (unless dependencies have changed)Closes #3124