Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3130 finance tab divided into subtabs #3139

Merged

Conversation

dreifusjack
Copy link
Contributor

@dreifusjack dreifusjack commented Jan 20, 2025

Changes

  • Added subtabs within the finance tab on the sidebar
  • Created new routes for new pages to be implemented
  • Created new dashboard and reimbursement request files to be implemented

Notes

I had to make the margin and padding between the sub-tabs tiny so they would fit without having the sidebar scrollable.

The original page tab will be removed eventually so ignore that it remains highlighted and makes the sidebar scrollable. For now it's just a reference when designing the other pages.

Screenshots

Screenshot 2025-01-23 at 11 07 58 PM Screenshot 2025-01-23 at 11 08 12 PM Screenshot 2025-01-20 at 3 18 44 PM

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3130

@dreifusjack dreifusjack self-assigned this Jan 20, 2025
@Peyton-McKee
Copy link
Contributor

are the tabs collapsible?

@dreifusjack
Copy link
Contributor Author

are the tabs collapsible?

Yes, when a user clicks Finance, the sub-tabs drop-down; if a user clicks Finance again, the sub-tabs are hidden. If the sub-tabs are visible and the user selects another tab like Teams or Projects, should the sub-tabs be hidden or visible?

@Peyton-McKee
Copy link
Contributor

id hide them if they select something else i think but id also ask @naishahmistry

@walker-sean walker-sean merged commit 09b3fbd into feature/finance-redesign Feb 1, 2025
4 checks passed
@walker-sean walker-sean deleted the #3130-Finance-Tab-Divided-Subtabs branch February 1, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants