Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3128: Schema Changes #3150

Merged

Conversation

wavehassman
Copy link
Contributor

@wavehassman wavehassman commented Jan 22, 2025

Changes

I added the necessary fields to the schema, and created a migration that linked reimbursement requests and projects together directly instead of going down a long rabbit hole. I also had to change the createVendor controller and service function, and bill of materials service function along with the seed data.

Notes

Even though I did a create only migration and then changed things around to make it the official one, it still made two migrations, not really sure why

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3128

@wavehassman wavehassman self-assigned this Jan 22, 2025
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
Copy link
Member

@walker-sean walker-sean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Make sure to update the seed data and endpoints to work with the migration. Before that, check that the migration works on unmigrated data

src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
src/backend/src/prisma/schema.prisma Outdated Show resolved Hide resolved
@walker-sean walker-sean merged commit 15f0b65 into feature/finance-redesign Feb 1, 2025
4 checks passed
@walker-sean walker-sean deleted the #3128-finance-redesign-schema-changes branch February 1, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants