-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3128: Schema Changes #3150
Merged
walker-sean
merged 7 commits into
feature/finance-redesign
from
#3128-finance-redesign-schema-changes
Feb 1, 2025
Merged
#3128: Schema Changes #3150
walker-sean
merged 7 commits into
feature/finance-redesign
from
#3128-finance-redesign-schema-changes
Feb 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walker-sean
requested changes
Jan 23, 2025
walker-sean
requested changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Make sure to update the seed data and endpoints to work with the migration. Before that, check that the migration works on unmigrated data
walker-sean
requested changes
Jan 27, 2025
walker-sean
requested changes
Jan 28, 2025
walker-sean
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I added the necessary fields to the schema, and created a migration that linked reimbursement requests and projects together directly instead of going down a long rabbit hole. I also had to change the createVendor controller and service function, and bill of materials service function along with the seed data.
Notes
Even though I did a create only migration and then changed things around to make it the official one, it still made two migrations, not really sure why
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lock
changes (unless dependencies have changed)Closes #3128