Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3143 Removed arrows on Add SABO # #3177

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

#3143 Removed arrows on Add SABO # #3177

wants to merge 4 commits into from

Conversation

wilsnwei
Copy link
Contributor

@wilsnwei wilsnwei commented Jan 30, 2025 •
edited
Loading

Changes

Removed arrows in text field for Add SABO # and removed 0 as default value

Screenshots

Screenshot 2025-02-02 at 5 32 49 PM Screenshot 2025-02-02 at 5 33 39 PM

Checklist

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3143

@wilsnwei wilsnwei requested a review from vsp05 January 30, 2025 19:34
@vsp05
Copy link
Contributor

vsp05 commented Feb 2, 2025

Great work! Would you be able to look into why the modal changes size when you start typing in it? Otherwise, looks good.

@vsp05
Copy link
Contributor

vsp05 commented Feb 5, 2025

Good work! Sorry to bug you with all these additional features, but I noticed when you add a SABO number, it doesn't update on the reimbursement request page until you refresh the page. You can use react hooks to make it automatically update when the addSABONumberModal is submitted. Do you think you could work on that? Sorry lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsp05 vsp05 Awaiting requested review from vsp05

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maintenance] - Get rid of arrows on "Add SABO #"
2 participants
@wilsnwei @vsp05