Switch lsm6dso to STM driver, test on MSB #191 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr1221
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Two things:
- Use the IFDEF convention with
SENSOR_IMUso it builds with SENSOR_IMU disabled and enabled (seemsb_conf.h. - Are we still using
accel_readandgyro_read? If not lets yeet them. And no matter what I prefer not to call the driver directly frommonitor.c, so can you add a very simple wrapper call (likeimu_data_get(...)inmsb.c?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set parameters to read/write IMU data. Works in conjunction with pull request in Embedded Base where new lsm6dso driver is installed.
Notes
The code style checks that fail are from functions that I copied from the old code under discretion of Jack. The build fails because it requires the PR from Embedded Base
Closes #191