Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#74 efficiency screen components #95

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

sumershinde22
Copy link
Collaborator

Changes

  • Completed the view of Efficiency Screen
  • Linked controller to qml and controller to the mock model

Screenshots

Screenshot 2024-04-04 at 5 33 33 PM

To Do

Any remaining things that need to get done

  • Adjust controller to match the values being displayed
  • Make controller implement the button controller class
  • add mock model values as necessary to ensure proper adjustment of the values in accordance to how it should function in reality
  • Add Video of it functioning as its supposed to

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #74

@sumershinde22 sumershinde22 self-assigned this Apr 4, 2024
@Peyton-McKee Peyton-McKee merged commit 868c81e into Develop Apr 9, 2024
1 check passed
@Peyton-McKee Peyton-McKee deleted the #74-Efficiency-Screen-Components branch April 9, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Efficiency Screen - Arrange and hook up components
2 participants