Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BMS Debug Mode, other fixups #152

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Improve BMS Debug Mode, other fixups #152

merged 2 commits into from
Jan 31, 2025

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Jan 25, 2025

Changes

  • Splits compute.c into compute.c and can_messages.c
  • Removes some header circular dependencies which made stuff confusing

Notes

Any other notes go here

Test Cases

  • Case A
  • Edge case
  • ...

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@jr1221 jr1221 self-assigned this Jan 25, 2025
@jr1221 jr1221 requested a review from Sabramz January 30, 2025 23:39
@jr1221 jr1221 merged commit 9a878fe into develop Jan 31, 2025
2 checks passed
@jr1221 jr1221 deleted the bms-debug-mode-extra branch January 31, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant