Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bms debug defs improvement #164

Merged
merged 7 commits into from
Feb 9, 2025
Merged

Bms debug defs improvement #164

merged 7 commits into from
Feb 9, 2025

Conversation

jr1221
Copy link
Contributor

@jr1221 jr1221 commented Feb 1, 2025

Changes

Explanation of changes goes here

Notes

Any other notes go here

Test Cases

  • Case A
  • Edge case
  • ...

To Do

Any remaining things that need to get done

  • item 1
  • ...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes # (issue #)

@Sabramz Sabramz self-requested a review February 6, 2025 02:07
Copy link
Contributor

@Sabramz Sabramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lisan al-Gaib

@Sabramz Sabramz merged commit daaaa79 into develop Feb 9, 2025
2 checks passed
@Sabramz Sabramz deleted the bms-debug-defs branch February 9, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants