Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional lsp installation #134

Merged
merged 14 commits into from
Sep 23, 2023
Merged

Optional lsp installation #134

merged 14 commits into from
Sep 23, 2023

Conversation

horriblename
Copy link
Collaborator

No description provided.

@horriblename horriblename marked this pull request as ready for review September 19, 2023 20:47
@horriblename horriblename marked this pull request as draft September 19, 2023 20:49
@horriblename horriblename force-pushed the optional-lsp-installation branch from 5b27d55 to 0a70d76 Compare September 19, 2023 20:52
@horriblename horriblename force-pushed the optional-lsp-installation branch from 0a70d76 to 0e66f62 Compare September 19, 2023 20:53
@horriblename horriblename marked this pull request as ready for review September 19, 2023 20:53
@horriblename
Copy link
Collaborator Author

removed the two functions you wrote because a) lib.nvim.lua.expToLua exists and b) some packages needed command+args so i removed pkgOrStr

@horriblename horriblename changed the base branch from optional-lsp-installation to main September 19, 2023 20:55
@horriblename
Copy link
Collaborator Author

oops forgot to add descriptions

@NotAShelf
Copy link
Owner

looks good, the list approach is unusual but should work as well as any other.

could I ask you to add this change to the changelog as well as add a page on the documentation describing custom LSP command usage?

@horriblename
Copy link
Collaborator Author

could I ask you to add this change to the changelog as well as add a page on the documentation describing custom LSP command usage?

where should I put it? in docs/manual/languages.adoc?

@horriblename
Copy link
Collaborator Author

release notes udpated, docs dumped into docs/manual/languages.adoc

@horriblename horriblename force-pushed the optional-lsp-installation branch from bda793a to cd778b6 Compare September 23, 2023 01:26
@NotAShelf
Copy link
Owner

I was thinking a custom chapter, but it probably belongs in languages chapter anyway. Thanks!

@NotAShelf NotAShelf merged commit 0a1a12e into NotAShelf:main Sep 23, 2023
6 checks passed
@NotAShelf NotAShelf mentioned this pull request Sep 23, 2023
Closed
1 task
@horriblename horriblename deleted the optional-lsp-installation branch September 23, 2023 12:04
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
@NotAShelf
Merge pull request NotAShelf#134 from horriblename/optional-lsp-insta…
35cea29 
…llation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horriblename @NotAShelf