Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop using deprecated buildVimPluginFrom2Nix #144

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: stop using deprecated buildVimPluginFrom2Nix #144

merged 1 commit into from
Oct 3, 2023

Conversation

jacekpoz
Copy link
Contributor

@jacekpoz jacekpoz commented Oct 3, 2023

I tested it by doing

neovim-flake = {
    url = "github:jacekpoz/neovim-flake/plugin-thingy-deprecation";
    inputs.nixpkgs.follows = "nixpkgs";
};

and rebuilding, it built and the plugins work

@jacekpoz jacekpoz requested a review from NotAShelf as a code owner October 3, 2023 18:09
@NotAShelf
Copy link
Owner

NotAShelf commented Oct 3, 2023

could you please test the maximal configuration with nix run .#maximal in the proejt root?

edit: no need, it was just a name change

Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work

@NotAShelf NotAShelf merged commit 6e4f702 into NotAShelf:main Oct 3, 2023
6 checks passed
@jacekpoz jacekpoz deleted the plugin-thingy-deprecation branch October 3, 2023 18:27
@horriblename
Copy link
Collaborator

uhhhhhh

vimplugin-diffview-nvim-master> Sourcing vim-command-check-hook.sh
vimplugin-diffview-nvim-master> Using vimCommandCheckHook
vimplugin-diffview-nvim-master> Sourcing vim-gen-doc-hook
vimplugin-diffview-nvim-master> Sourcing neovim-require-check-hook.sh
vimplugin-diffview-nvim-master> Using neovimRequireCheckHook
vimplugin-diffview-nvim-master> unpacking sources
vimplugin-diffview-nvim-master> unpacking source archive /nix/store/bkdnk4sddvdyzygaxmlj9lmyw012qy6n-source
vimplugin-diffview-nvim-master> source root is source
vimplugin-diffview-nvim-master> patching sources
vimplugin-diffview-nvim-master> updateAutotoolsGnuConfigScriptsPhase
vimplugin-diffview-nvim-master> configuring
vimplugin-diffview-nvim-master> no configure script, doing nothing
vimplugin-diffview-nvim-master> building
vimplugin-diffview-nvim-master> build flags: SHELL=/nix/store/p6dlr3skfhxpyphipg2bqnj52999banh-bash-5.2-p15/bin/bash
vimplugin-diffview-nvim-master> nvim --headless -i NONE -n -u scripts/minimal_init.lua -c \
vimplugin-diffview-nvim-master>         "PlenaryBustedDirectory tests/ { minimal_init = './scripts/minimal_init.lua' }"
vimplugin-diffview-nvim-master> Installing nvim-lua/plenary.nvim
vimplugin-diffview-nvim-master> Error detected while processing /build/source/scripts/minimal_init.lua:
vimplugin-diffview-nvim-master> E5113: Error while calling lua chunk: Vim:E475: Invalid value for argument cmd: 'git' is not executable
vimplugin-diffview-nvim-master> stack traceback:
vimplugin-diffview-nvim-master>         [C]: in function 'system'
vimplugin-diffview-nvim-master>         /build/source/scripts/minimal_init.lua:15: in function 'load'
vimplugin-diffview-nvim-master>         /build/source/scripts/minimal_init.lua:29: in function 'setup'
vimplugin-diffview-nvim-master>         /build/source/scripts/minimal_init.lua:36: in main chunk
vimplugin-diffview-nvim-master> Error detected while processing /nix/store/m8walnvbazdfl0aza26j614xx734rsvg-neovim-unwrapped-0.9.1/share/nvim/runtime/plugin/rplugin.vim[70]..function <SNR>12_LoadRemotePlugins[5]..<SNR>12_GetManifest[1]..<SNR>12_GetManifestPath:
vimplugin-diffview-nvim-master> line   10:
vimplugin-diffview-nvim-master> E739: Cannot create directory /homeless-shelter: permission denied
vimplugin-diffview-nvim-master> Error detected while processing command line:
[1/0/39 built] building vimplugin-diffview-nvim-master (buildPhase)

diffview stuck in buildPhase

other plugins seem broken as well

@horriblename
Copy link
Collaborator

(confirmed working in fc8206e, this PR is the culprit)

@horriblename
Copy link
Collaborator

oops it was just caused by old nixpkgs version

@NotAShelf bump nixpkgs thanks

@NotAShelf
Copy link
Owner

@horriblename bumping nixpkgs break docs building at the moment, but you can override nixpkgs input manually on your own end with inputs.nixpkgs.follows

This was referenced Oct 4, 2023
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants