-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use nixosOptionDocs #177
Conversation
NixOS 23.11 is deprecating DocBook option documentation. Following home-manager in this change is probably a good idea
@horriblename building options.json currently fails with |
oops missing description diff --git a/lib/types/plugins.nix b/lib/types/plugins.nix
index 344c405..ee33a42 100644
--- a/lib/types/plugins.nix
+++ b/lib/types/plugins.nix
@@ -112,6 +112,7 @@ with lib; let
options = {
package = mkOption {
type = pluginType;
+ description = "Plugin Package.";
};
after = mkOption {
type = listOf str; build still not passing tho, this time failing on
do you know what's going on? |
I might have an idea, I'll see if that helps |
neat, that did the trick |
i.e.
instead of
|
that is interesting, we're basically following home-manager in regards of nmd usage - but features that it's able to use don't apply to us, which seems to be all CommonMark features? |
after little research, I've noticed that |
Okay, I believe |
Might be because it's an example? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Ching Pei Yang <[email protected]>
682a583
to
385d91f
Compare
docs: use nixosOptionDocs
NixOS 23.11 is deprecating DocBook option documentation. Following home-manager in this change is probably a good idea. This change drops
literalDocBook
and the provided nmd functions in favor of nixosOptionDocs and CommonMark in option descriptions.