Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

languages/nim: init #205

Merged
merged 3 commits into from
Feb 10, 2024
Merged

languages/nim: init #205

merged 3 commits into from
Feb 10, 2024

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Feb 7, 2024 •
edited
Loading

Take two, properly rebased this time.

  • Implements Nim LSP and formatter support which I have tested briefly. Seems to be working, but LSP sometimes takes a second or two to kick in before we actually get diagnostics

@NotAShelf NotAShelf added enhancement New feature or request help wanted Extra attention is needed labels Feb 7, 2024
@FrothyMarrow
Copy link
Contributor

Tested the PR on Linux and it seems to work fine. On MacOS, NimLSP crashes because of segment violation. I have created an issue (PMunch/nimlsp#178 (comment)), meanwhile maybe mark the support for nim as broken on MacOS?

@NotAShelf
Copy link
Owner Author

I'll add an assertion

@NotAShelf
Copy link
Owner Author

@FrothyMarrow pushed a commit to assert on Darwin systems. Given I don't have a way to test it, would appreciate if you could test it.

@FrothyMarrow
Copy link
Contributor

The assert works but it will also fail the maximal builds on Darwin. I believe it would be better to have it either disabled by default or add a check there as well.

@NotAShelf
languages/nim: assert on darwin systems
6346617 
due to nimlsp not working properly on darwin
FrothyMarrow
FrothyMarrow approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@FrothyMarrow FrothyMarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NotAShelf NotAShelf merged commit 4e83912 into main Feb 10, 2024
7 checks passed
@NotAShelf NotAShelf deleted the nim-lang branch February 10, 2024 13:11
@NotAShelf NotAShelf mentioned this pull request Feb 22, 2024
Open
8 tasks
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
@NotAShelf
Merge pull request NotAShelf#205 from NotAShelf/nim-lang
73ff34e 
languages/nim: init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrothyMarrow FrothyMarrow FrothyMarrow approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotAShelf @FrothyMarrow