-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utility/preview: added markdown-previewer.nvim and moved glow #217
Conversation
I'm not sure if we really want the previewer in languages/markdown.nix directly. Generally companion plugins are sorted by function and not language, going under ! |
Fair point. I thought about moving it, but didn't because Glow already was there. I'll keep that in mind for future PRs. I'll make a new commit in a little bit. |
608fcbf
to
c2b871e
Compare
c2b871e
to
319aaca
Compare
I hope this new commit is satisfactory. If not, let me know, and I'll change it. It moves both glow and markdown-preview to a new preview category in utility. I also fixed |
19bd8ed
to
bf732bc
Compare
While the IP-address and port options do play nicely with empty strings, they're not specified to be empty strings in upstream, just empty (unlike other options). I therefore added |
LGTM! requesting a review from @FrothyMarrow, given the relatively large scope of the PR in case I've missed anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bf732bc
to
2e07763
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merging when the CI passes. |
Missing documentation, but I'll add it. Thanks! |
utility/preview: added markdown-previewer.nvim and moved glow
Description
Added markdown-previewer.nvim as a Markdown previewer and moved both it and glow to a new category: utility/preview.
Type of change
Checklist
nix fmt
).Screenshots & Logs