Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6 #231

Merged
merged 223 commits into from
Apr 28, 2024
Merged

v0.6 #231

merged 223 commits into from
Apr 28, 2024

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Feb 19, 2024

Continuation of #197. Rebased around v0.6 branch to avoid merge conflicts.

TODO

  • neo-tree
  • Move dashboard plugins to the new setupOpts format
  • Re-visit tabline, lualine and scrollbar configurations
  • Base16 theming

Things I might want to do:

  • Other suggestions by contributors and maintainers alike
  • Look into lazy loading via Lazy (CC: @horriblename)

Done

  • Switch to makeNeovimConfig, or move to "unstable" neovim wrapper
  • rebase fidget.nvim around the latest master (previously legacy branch) by FrothyMarrow
  • always include lua parser with treesitter by FrothyMarrow
  • allow configurable category labels with which-key by FrothyMarrow
  • add image.nvim by NotAShelf
  • move home-manager module to a directory dedicated to modules, accommodating for the possibilities of NixOS and Darwin modules in the future. by NotAShelf
    • lib/modules/default.nix -> flake/modules/hm-module.nix
  • Clean up the initial root directory of the project.
    • Files that belong in their respective directories (e.g. assets) to be moved
  • Reduce dependency cycles and layered imports in modules/
    • All plugins to be moved to modules/plugins/
    • Option definitions separated from configurations
    • Basic and Core to be isolated as modules/core and modules/neovim (previously basic)`
      • core will contain wrapper and build related files
      • neovim will contain the most basic vim/neovim options that are passed to base configurations.
  • Cleans up and re-organizes lib so that files and functions are easier to search by name.
    • Revisit lib structure, overlay lib functions so that they are available on on top level (e.g. lib.toLuaObject as well as lib.lua.toLuaObject)
  • Move neovim config builder/helper functions into lib, and call from lib where necessary. This has been an issue while implementinig the home manager module, and I'd like to avoid repeating the same mistake again.
  • Make lib usage more explicit -> Instead of inherit (lib) concatStringsSep, we use inherit (lib.strings) concatStringsSep to ensure clarity. This slightly clutters the beginning of each file, but it's more understandable where exactly the function comes from (especially when working with the extended lib)

@NotAShelf NotAShelf force-pushed the v0.6 branch 2 times, most recently from 09d0747 to e88c3c8 Compare February 26, 2024 05:05
@NotAShelf NotAShelf force-pushed the v0.6 branch 2 times, most recently from 0b69e17 to c986012 Compare February 26, 2024 08:09
@NotAShelf
Copy link
Owner Author

NotAShelf commented Feb 26, 2024

@horriblename sorry for moving around so much, I'll have to ask you to rebase #228, #229 and #230 around this PR again. This should be the final, but it also means that we're feature freezing main for the time being.

@NotAShelf NotAShelf mentioned this pull request Feb 26, 2024
8 tasks
@NotAShelf NotAShelf requested a review from horriblename April 27, 2024 13:14
NotAShelf and others added 6 commits April 27, 2024 16:22
docs/manual/hacking/guidelines.md Outdated Show resolved Hide resolved
jacekpoz and others added 2 commits April 27, 2024 19:39
horriblename
horriblename previously approved these changes Apr 28, 2024
Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf NotAShelf merged commit fde2988 into main Apr 28, 2024
7 checks passed
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
@NotAShelf NotAShelf deleted the v0.6 branch November 10, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants