Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: restructure neovim-flake tree #245

Merged
merged 14 commits into from
Apr 14, 2024
Merged

treewide: restructure neovim-flake tree #245

merged 14 commits into from
Apr 14, 2024

Conversation

NotAShelf
Copy link
Owner

@NotAShelf NotAShelf commented Apr 7, 2024

Take three of #197 and #225.


DONE

  1. Reduces dependency cycles and layered imports in modules/

    • All plugins have been moved to modules/plugins/
    • Option definitions separated from configurations
    • Basic and Core have been isolated as modules/core and modules/neovim (previously basic)`
      • core will contain wrapper and build related files
      • neovim will contain the most basic vim/neovim options that are passed to base configurations.
  2. Cleans up and re-organizes lib so that files and functions are easier to search by name.

  3. Moves vim-dirtytalk to plugins.

TODO/TBD

Things I want to do:

  • Move neovim config builder/helper functions into lib, and call from lib where necessary. This has been an issue while implementing the home manager module, and I'd like to avoid repeating the same mistake again.

Things I might want to do:

  • Get rid of inputs per-plugin. It's a nice idea, but flakes suck. Hundreds of inputs that a user will likely not even think about overriding in their whole usage of this flake is, I assume, burdening. If my fellow co-maintainers @FrothyMarrow and @horriblename agree; I'd like to fall back to either customizable package options, or a packages list that gets passed to Neovim wrapper.
  • Other suggestions by contributors and maintainers alike

@NotAShelf NotAShelf marked this pull request as draft April 7, 2024 14:19
@NotAShelf NotAShelf marked this pull request as ready for review April 9, 2024 06:56
@NotAShelf
Copy link
Owner Author

I officially consider this ready to go, it's not perfect but I will revise the structure as the need arises. I wanted to revise lib a bit, but I think that's going to be to big of an endeavor right now - one that I do not have the energy for. Unless @horriblename or @FrothyMarrow have a request or any requests for changes, this can be merged.

none, relative, number, relNumber
How line numbers are displayed.

Available options are:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type should already say what's available, I think we can delete this part

@NotAShelf NotAShelf force-pushed the new-tree-structure branch from dee642e to 6011ec2 Compare April 14, 2024 11:20
@NotAShelf NotAShelf merged commit b1d6ec7 into v0.6 Apr 14, 2024
7 checks passed
@NotAShelf NotAShelf deleted the new-tree-structure branch April 14, 2024 12:09
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
treewide: restructure neovim-flake tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants