Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

languages/julia: init #431

Merged
merged 1 commit into from
Nov 2, 2024
Merged

languages/julia: init #431

merged 1 commit into from
Nov 2, 2024

Conversation

diniamo
Copy link
Collaborator

@diniamo diniamo commented Oct 31, 2024

Sanity Checking

  • I have updated the changelog as per my changes.
  • I have tested, and self-reviewed my code.
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt).
    • My code conforms to the editorconfig configuration of the project.
    • My changes are consistent with the rest of the codebase.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual.
    • (For breaking changes) I have included a migration guide.
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@diniamo diniamo requested a review from NotAShelf as a code owner October 31, 2024 13:46
Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the tiny nitpick

docs/release-notes/rl-0.7.md Outdated Show resolved Hide resolved
@diniamo diniamo force-pushed the julia branch 2 times, most recently from 3863c70 to 45f58ed Compare October 31, 2024 23:50
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick changes for consistency.

Not a deal-breaker, but I'd appreciate it if the order of mkOption args was

{
  type = ...;
  default = ...;
  (optional) example = ...;
  description = ...;
}

@NotAShelf NotAShelf merged commit c6453c4 into NotAShelf:v0.7 Nov 2, 2024
7 checks passed
@NotAShelf NotAShelf mentioned this pull request Nov 8, 2024
@diniamo diniamo deleted the julia branch December 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants