languages: inherit lspconfig options from language options #643
+141
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
NotAShelf
changed the title
NotAShelf
force-pushed
the
lsp-configuration-opts
branch
from
0a00dd5 to
d827ac8
Compare
This was referenced Feb 18, 2025
horriblename
requested changes
Feb 20, 2025
| description = "Filetypes to auto-attach LSP in"; | ||
| }; | ||
|
|
||
| cmd = mkOption { |
There was a problem hiding this comment.
do you think it's necessary to split this into cmd, args? someone might want to override the cmd but keep the args
| package = pkgs.asm-lsp; | ||
| options = { | ||
| capabilities = mkLuaInline "capabilities"; | ||
| on_attach = mkLuaInline "attach_keymaps"; |
There was a problem hiding this comment.
why not default_on_attach?
| options = { | ||
| capabilities = mkOption { | ||
| type = luaInline; | ||
| default = mkLuaInline "default_capabilities"; |
There was a problem hiding this comment.
just "capabilities" I'm pretty sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.