Fix world unload event invocation and registry entry removal when unl…

…oading worlds (#35) * fix unload event invocation and registry entry removal * move unload event call after the save to conform to vanilla
NucleoidMC · Dec 7, 2023 · 6719e00 · 6719e00
1 parent 8e2bd96
commit 6719e00
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/main/java/xyz/nucleoid/fantasy/RuntimeWorldManager.java b/src/main/java/xyz/nucleoid/fantasy/RuntimeWorldManager.java
@@ -101,13 +101,13 @@ public void setTask(Text task) {}
                 public void progressStagePercentage(int percentage) {}
 
                 @Override
-                public void setDone() {
-                    ServerWorldEvents.UNLOAD.invoker().onWorldUnload(RuntimeWorldManager.this.server, world);
-
-                    SimpleRegistry<DimensionOptions> dimensionsRegistry = getDimensionsRegistry(RuntimeWorldManager.this.server);
-                    RemoveFromRegistry.remove(dimensionsRegistry, dimensionKey.getValue());
-                }
+                public void setDone() {}
             }, true, false);
+
+            ServerWorldEvents.UNLOAD.invoker().onWorldUnload(RuntimeWorldManager.this.server, world);
+
+            SimpleRegistry<DimensionOptions> dimensionsRegistry = getDimensionsRegistry(RuntimeWorldManager.this.server);
+            RemoveFromRegistry.remove(dimensionsRegistry, dimensionKey.getValue());
         }
     }