Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #21

Merged
merged 9 commits into from
Dec 21, 2024
Merged

Upgrade dependencies #21

merged 9 commits into from
Dec 21, 2024

Conversation

ashhhleyyy
Copy link
Member

@ashhhleyyy ashhhleyyy commented Dec 20, 2024 •
edited
Loading

not tested yet now tested
includes a breaking change that needs to be made in nucleoid-extras at the same time:

@ashhhleyyy ashhhleyyy marked this pull request as ready for review December 21, 2024 13:33
@ashhhleyyy ashhhleyyy requested a review from Gegy December 21, 2024 13:33
@ashhhleyyy ashhhleyyy mentioned this pull request Dec 21, 2024
Merged
Gegy
Gegy approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@Gegy Gegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like some really nice cleanups, thanks for figuring out all those upgrades! \o/
Just had some tiny nits, but totally optional :)

src/discord.rs Outdated Show resolved Hide resolved
src/discord/lfp.rs Outdated Show resolved Hide resolved
@ashhhleyyy ashhhleyyy merged commit f05fe4e into main Dec 21, 2024
2 checks passed
@ashhhleyyy ashhhleyyy deleted the ash/upgrade-deps branch December 21, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gegy Gegy Gegy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashhhleyyy @Gegy