-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ale translation spanish #404
base: master
Are you sure you want to change the base?
Conversation
translation to spanish
english to spanish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review - mostly pointing out missing translations and formatting quirks.
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
@ozhang22 can you please review it again? I corrected all the missing translations. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more formatting issues, but looks good.
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
Co-authored-by: Oliver Zhang <[email protected]>
@beagandica would you mind double checking this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ale, thank you so much for doing this work!
I made comments but in general:
- use Tu vs Usted as it is for kids
- Instead of Gato game, let's use Tres en raya (i added two options for you to decide)
- The code (.xml, .gradle, .kt, etc) should the comments and details be translated as well or ok to leave in english? i believe english should be fine
|
||
## Comienza tu aventura de juego para Android | ||
|
||
¿Alguna vez te has preguntado cómo podrías construir tu propio juego de Gato? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
¡Estas de suerte, hoy es el día, podrás construir el tuyo! | ||
|
||
<img src="resources/_gen/images/game_play.gif" height="30%" width="22%" title="Juego del Gato en Android" alt="Juego del Gato en Android"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si hacemos tres en raya, hay que cambiarlo en todo el documento.
|
||
## Acerca de este Proyecto | ||
|
||
En este proyecto te hemos dado una aplicación Android que funciona principalmente que es un juego de Tic-Tac-Toe. ¡Necesita tu ayuda para solucionar algunos problemas y agregar algunas partes para que sea un gran juego! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tic-tac-toe esta en ingles, entonces una vez que decidas si tres en raya en vez de gato hay dos opciones pero deben ser throughout the workshop:
- Tres en raya
- Tres en raya (tic-tac-toe)
me gusta mas la segunda porque el que no entienda tres en raya puede entender que se refiere a tic-tac-toe
|
||
Para comenzar, descargue los archivos del proyecto siguiendo estos pasos: | ||
1. [Descarga los archivos de proyecto](../resources/_gen/files/TicTacToe.zip) para tu juego. | ||
2. Busque el archivo TicTacToe.zip en su carpeta de descargas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otra razon para usar la opcion 2, ya que todos los files en ingles dicen tic-tac-toe
|
||
|
||
## Establecer la variable de entorno JAVA_HOME | ||
Android Studio viene con una versión de Java necesaria para que ciertas partes de la aplicación se ejecuten. Siga los pasos a continuación para establecer la variable de entorno `JAVA_HOME` en su computadora, que le indica a estas herramientas dónde encontrar Java: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usar usted or tu pero en todo el documento.
deberia ser ... en tu computadora ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lo mismo con esta - si se puede recreas seria super
draft: false | ||
weight: 7 | ||
--- | ||
Todo lo que está rodeado de comillas se denomina cadena. Así es como una computadora representa palabras u oraciones. Por ejemplo, `"a"`, `"2"`, `"banana!" `, y `"Hello World"` son cadenas, pero `Hello World` y `2` no son cadenas, porque faltan las comillas. Puede combinar muchas cadenas juntas usando el operador +. Por ejemplo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cadena o string en ingles.
como es la primera vez, vale la pena colocarlo. que piensas?
- `"Nuevo" + " " + "Fundación"` produce la cadena `"Fundación Nuevo"`. | ||
|
||
{{% notice tip %}} | ||
## Trabajando Juntos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creo q falta una linea entre linea 12 y 13
## Trabajando Juntos | ||
|
||
|
||
Elimina todo el texto `System.out.println` en su código. Inicia su código con la línea `System.out.println("Nuevo" + " " + "Foundation");`. Ten en cuenta que hay muchas maneras de combinar cadenas. Por ejemplo, otra forma de mostrar Fundación Nuevo sería escribir ´System.out.println("Nue" + "vo Fou" + "ndation");`. Haremos una lluvia de ideas sobre al menos una forma más de mostrar la cadena ´"Nuevo Foundation"´ usando dos símbolos ´+´ en cada instrucción `System.out.println`. Verifica que Nuevo Foundation se muestre 3 veces. En otras palabras, la consola debería verse así después de presionar el botón de ejecutar: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deberia ser Nuevo Foundation, no Fundacion Nuevo
@@ -0,0 +1,21 @@ | |||
# Add project specific ProGuard rules here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
igual aqui, esto deberia ser en espanol o dejarlo asi, no lo se @ozhang22 @oliver-zhang-neuvo
This is the completed workshop of android tic tac toe translated to Spanish.