Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix headless contact icon #30

Closed
wants to merge 2 commits into from
Closed

Conversation

reality-exe
Copy link

Made icons show regardless if weather or not the Headless user is in a shown session or not

@Nutcake
Copy link
Owner

Nutcake commented Aug 22, 2023

Thanks for the PR!

Are you sure this approach always works? I could have sworn there are cases when the API doesn't always return this information correctly which is why I went for this hacky solution in the first place, but it's been a while since I've looked into it.

Also I'd appreciate it if you could change the commit message to be imperative case (Fix headless contact icon).

@reality-exe
Copy link
Author

So far yes, it seems to be working with the headless' I have added (5 in total).

And yeah sure I'll change the title though that's more accurate for grammar

@reality-exe reality-exe changed the title Fixed headless contact icon Fix headless contact icon Aug 22, 2023
@Nutcake
Copy link
Owner

Nutcake commented Aug 22, 2023

Imperative should be used to follow long standing git conventions. I follow this convention for all my commit messages and prefer things to be consistent. Grammatically this isn't an issue, as instead of saying what a commit does, you are basically *telling* the commit what it should do.

For adjusting the message, I don't mean the title on the PR, I mean the actual commit message itself.
You can change this by editing your local commit with the --amend option and then force-pushing to this branch.

@reality-exe
Copy link
Author

Man im using the github desktop client i dunno how to do dat

Added extra icons to the friends list and added a friend dialog (Long press on a chat)
@Nutcake
Copy link
Owner

Nutcake commented Sep 5, 2023

Closing this as the branch to pull in now has changes that are obviously meant to be a separate fork instead and contains things that aren't supposed to be in here (changing the app-id, adding vscode project file, changing credits) and no attempt to fix the inconsistent commit message has been made.

@Nutcake Nutcake closed this Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants