Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Move the constraint on uniqueness for cutoff date at line level… #310

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

lmarion-source
Copy link

… + Add the possibility to create several cutoff with the same date

Business case can be :

  • One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff. However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines, only retrieves the one that were not already in the cutoff of A.

  • One user wants to create several cutoff at the same date, but for different journals/accounts

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via, @jbaudoux,
some modules you are maintaining are being modified, check this out!

@lmarion-source lmarion-source force-pushed the 16.0-multiple_cutoff branch 2 times, most recently from 554ee1a to d265d1f Compare November 14, 2024 14:52
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, you cannot do such change because it has an impact on many other cutoff modules. Can't you leverage the user on cutoff entries instead of creating a separate new cutoff?

Side note: you should make one commit per module

account_cutoff_base/__manifest__.py Outdated Show resolved Hide resolved
… + Add the possibility to create several cutoff with the same date

Business case can be :

- One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
  However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
  only retrieves the one that were not already in the cutoff of A.

- One user wants to create several cutoff at the same date, but for different journals/accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants