Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] commission: Migration to 17.0 #496

Closed
wants to merge 2 commits into from
Closed

[17.0][MIG] commission: Migration to 17.0 #496

wants to merge 2 commits into from

Conversation

ambientWave
Copy link
Contributor

@ambientWave ambientWave commented Jan 19, 2024

I upgraded the three main modules, which have the following technical names:
'commission', 'sale_commission', 'account_commission'
to be installed on Odoo 17.0.
The demo files weren't upgraded and hence, an error during installation is warning user that demo data wasn't populated. However, all modules can be used without demo data.
All contributions and comments are welcomed.

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0. And you should do one module per PR.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@ambientWave ambientWave mentioned this pull request Jan 19, 2024
7 tasks
@ambientWave ambientWave changed the base branch from 17.0 to 16.0 January 19, 2024 08:30
@ambientWave
Copy link
Contributor Author

@pedrobaeza If I am considering to re-run the steps as provided in the technical guide you provided, should I make different repository for each module?

@pedrobaeza
Copy link
Member

One branch per module.

@ambientWave
Copy link
Contributor Author

ambientWave commented Jan 19, 2024

@pedrobaeza would you endorse deleting my repository and restart a clean one with same name or what should I do if I intend to push the migrated repository that I crafted by following the steps?
Almost forgot to thank you for your quick replies

@pedrobaeza
Copy link
Member

I can't do that things, as it's your repository. You just need to create as many branches as you need. https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants