Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] sale_commission_partial_settlement: major refactor #586

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

aleuffre
Copy link

@aleuffre aleuffre commented Dec 17, 2024

This commit refactors the data structure of the module entirely,
in order to provide both a forecast and more detailed
traceability of partial commissions, from invoice to
settlement.

The new data structure is a better fit for the way invoices
and moves work in base Odoo as well.

@OCA-git-bot
Copy link
Contributor

Hi @renda-dev, @PicchiSeba,
some modules you are maintaining are being modified, check this out!

@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch from bd40ece to 1cbea36 Compare December 20, 2024 08:55
@aleuffre aleuffre marked this pull request as ready for review December 20, 2024 11:23
@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch 2 times, most recently from 0b5783b to 129ec2c Compare December 20, 2024 16:03
@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch 8 times, most recently from 6ff81cb to 8c3866e Compare January 20, 2025 09:56
@aleuffre aleuffre changed the title DO NOT MERGE: sale_commission_partial_settlement: major refactor [14.0][FIX] sale_commission_partial_settlement: major refactor Jan 20, 2025
@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch 6 times, most recently from f25b673 to 9d41fd7 Compare January 22, 2025 13:42
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch from 9d41fd7 to 26a4a27 Compare January 27, 2025 16:13
This commit refactors the data structure of the module entirely,
in order to provide both a forecast and more detailed
traceability of partial commissions, from invoice to
settlement.

The new data structure is a better fit for the way invoices
and moves work in base Odoo as well.
@aleuffre aleuffre force-pushed the 14.0-commission-partial-settled branch from 26a4a27 to ce30bfa Compare January 27, 2025 16:14
Copy link

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

ps. kudos for the great work

@PicchiSeba
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-586-by-PicchiSeba-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 27, 2025
Signed-off-by PicchiSeba
@OCA-git-bot
Copy link
Contributor

@PicchiSeba your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-586-by-PicchiSeba-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@aleuffre
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-586-by-aleuffre-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f633e47 into OCA:14.0 Jan 27, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e9ebdc9. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-commission-partial-settled branch January 28, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants