-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] sale_commission_partial_settlement: major refactor #586
[14.0][FIX] sale_commission_partial_settlement: major refactor #586
Conversation
Hi @renda-dev, @PicchiSeba, |
bd40ece
to
1cbea36
Compare
0b5783b
to
129ec2c
Compare
6ff81cb
to
8c3866e
Compare
f25b673
to
9d41fd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9d41fd7
to
26a4a27
Compare
This commit refactors the data structure of the module entirely, in order to provide both a forecast and more detailed traceability of partial commissions, from invoice to settlement. The new data structure is a better fit for the way invoices and moves work in base Odoo as well.
26a4a27
to
ce30bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review: LGTM
ps. kudos for the great work
/ocabot merge nobump |
On my way to merge this fine PR! |
@PicchiSeba your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-586-by-PicchiSeba-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e9ebdc9. Thanks a lot for contributing to OCA. ❤️ |
This commit refactors the data structure of the module entirely,
in order to provide both a forecast and more detailed
traceability of partial commissions, from invoice to
settlement.
The new data structure is a better fit for the way invoices
and moves work in base Odoo as well.