[16.0[IMP]account_commission: add payment date limit on settle commissions #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pedrobaeza, |
matteonext
force-pushed
the
16.0-imp-account_commission
branch
from
ba276da to
50f6a32
Compare
matteonext
changed the title
PicchiSeba
suggested changes
Dec 20, 2024
| @@ -251,7 +251,30 @@ def _skip_settlement(self): | |||
| :return: bool | |||
| """ | |||
| self.ensure_one() | |||
| payment_based_commission = ( | |||
| True if self.commission_id.invoice_state == "paid" else False | |||
There was a problem hiding this comment.
nitpick: this expression could be simplified
Suggested change
| True if self.commission_id.invoice_state == "paid" else False | |
| self.commission_id.invoice_state == "paid" |
matteonext
force-pushed
the
16.0-imp-account_commission
branch
from
50f6a32 to
8a9338b
Compare
PicchiSeba
reviewed
Feb 28, 2025
Comment on lines
+57
to
+59
| context_date_payment = self.env.context.copy() | ||
| context_date_payment["date_payment_to"] = self.date_payment_to | ||
| self.env.context = context_date_payment |
There was a problem hiding this comment.
question: aren't these operations equivalent to
self.env.context["date_payment_to"] = self.date_payment_to?
Or am I missing something?
There was a problem hiding this comment.
Hi @PicchiSeba, self.env.context is a frozendict, which is an immutable dictionary. Because of this, I couldn't add self.date_payment_to directly as you suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #441